mirror of
https://github.com/NoFxAiOS/nofx.git
synced 2025-12-06 13:54:41 +08:00
3.8 KiB
3.8 KiB
Pull Request
📝 Description
🎯 Type of Change
- 🐛 Bug fix (non-breaking change which fixes an issue)
- ✨ New feature (non-breaking change which adds functionality)
- 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
- 📝 Documentation update
- 🎨 Code style update (formatting, renaming)
- ♻️ Refactoring (no functional changes)
- ⚡ Performance improvement
- ✅ Test update
- 🔧 Build/config change
🔗 Related Issues
- Closes #
- Related to #
📋 Changes Made
- Change 1
- Change 2
- Change 3
🧪 Testing
Manual Testing
- Tested locally (manual verification)
- Tested on testnet (for exchange integrations)
- Tested with different configurations
- Verified no existing functionality broke
Test Environment
- OS: [e.g. macOS, Ubuntu]
- Go Version: [e.g. 1.21.5]
- Exchange: [if applicable]
Test Results
Test output here
📸 Screenshots / Demo
Before:
After:
✅ Checklist
Code Quality
- My code follows the project's code style (Contributing Guide)
- I have performed a self-review of my code
- I have commented my code, particularly in hard-to-understand areas
- My changes generate no new warnings or errors
- Code compiles successfully (
go build/npm run build) - I have run
go fmt(for Go code)
Testing
- I have added tests that prove my fix is effective or that my feature works
- New and existing unit tests pass locally
- I have tested on testnet (for trading/exchange changes)
Documentation
- I have updated the documentation accordingly
- I have updated the README if needed
- I have added inline code comments where necessary
- I have updated type definitions (for TypeScript changes)
Git
- My commits follow the conventional commits format (
feat:,fix:, etc.) - I have rebased my branch on the latest
devbranch - There are no merge conflicts
🔒 Security Considerations
- No API keys or secrets are hardcoded
- User inputs are properly validated
- No SQL injection vulnerabilities introduced
- Authentication/authorization properly handled
- N/A (not security-related)
⚡ Performance Impact
- No significant performance impact
- Performance improved
- Performance may be impacted (explain below)
📚 Additional Notes
For Bounty Claims
- This PR is for bounty issue #
- All acceptance criteria from the bounty issue are met
- I have included a demo video/screenshots
- I am ready for payment upon merge
Payment Details:
🙏 Reviewer Notes
By submitting this PR, I confirm that:
- I have read the Contributing Guidelines
- I agree to the Code of Conduct
- My contribution is licensed under the MIT License