From 6769a46d71508a24f4e2d4dc14aa4aebd826bf38 Mon Sep 17 00:00:00 2001
From: elrrrrrrr <elrrrrrrr@gmail.com>
Date: Sat, 25 Mar 2023 21:40:50 +0800
Subject: [PATCH] fix: download row create error (#1749)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

> 包名超长时，更新下载记录接口会无限重试
* 更新下载记录前，先判断当前包名是否存在

-------------

> When the package name is too long, the update download record
interface will retry indefinitely.

* Check pkg exists, before updating the download record.
---
 controllers/registry/package/download.js | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/controllers/registry/package/download.js b/controllers/registry/package/download.js
index 801916d..49aa9e2 100644
--- a/controllers/registry/package/download.js
+++ b/controllers/registry/package/download.js
@@ -130,9 +130,12 @@ defer.setInterval(function* () {
         err.message += '; name: ' + name + ', count: ' + count + ', date: ' + date;
         logger.error(err);
       }
-      // save back to globalDownloads, try again next time
-      count = (globalDownloads.get(name) || 0) + count;
-      globalDownloads.set(name, count);
+      var pkgExist = yield packageService.getModuleLastModified(name);
+      if (pkgExist) {
+        // save back to globalDownloads, try again next time
+        count = (globalDownloads.get(name) || 0) + count;
+        globalDownloads.set(name, count);
+      }
     }
   }
   saving = false;